Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[modsecurity] Ensure event.kind is correctly set for pipeline errors #6672

Merged
merged 5 commits into from
Jun 22, 2023
Merged

[modsecurity] Ensure event.kind is correctly set for pipeline errors #6672

merged 5 commits into from
Jun 22, 2023

Conversation

MakoWish
Copy link
Contributor

What does this PR do?

Modify modsecurity integration to correctly set event.kind for pipeline errors and ensure error.message is an array.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  •  

How to test this PR locally

Related issues

Screenshots

@MakoWish MakoWish requested a review from a team as a code owner June 22, 2023 14:28
@elasticmachine
Copy link

elasticmachine commented Jun 22, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-22T21:25:49.633+0000

  • Duration: 15 min 31 sec

Test stats 🧪

Test Results
Failed 0
Passed 7
Skipped 0
Total 7

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@efd6
Copy link
Contributor

efd6 commented Jun 22, 2023

/test

@efd6 efd6 mentioned this pull request Jun 22, 2023
Closed
@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (3/3) 💚
Classes 100.0% (3/3) 💚
Methods 100.0% (30/30) 💚
Lines 91.582% (359/392) 👎 -2.958
Conditionals 100.0% (0/0) 💚

efd6
efd6 approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@efd6 efd6 merged commit 742e32a into elastic:main Jun 22, 2023
@MakoWish MakoWish deleted the 6582-modsecurity branch June 22, 2023 21:48
@elasticmachine
Copy link

Package modsecurity - 1.10.0 containing this change is available at https://epr.elastic.co/search?package=modsecurity

@andrewkroh andrewkroh added the Integration:modsecurity ModSecurity Audit label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efd6 efd6 efd6 approved these changes

Assignees
No one assigned
Labels
Integration:modsecurity ModSecurity Audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MakoWish @elasticmachine @efd6 @andrewkroh